Skip to content

Conversation

Iskander14yo
Copy link
Contributor

This PR adds Apache Comet as a backend for Spark in analytical workloads. Base issue - #517.

Notes:

  • I did not rewrite the queries as initially proposed in the issue. This can be done later — for now, I’d like to focus on verifying setup correctness.
  • I tried to reuse existing Spark code in the form of copy-paste-document.

Also I consider creating issue in Comet repo for devs to double-check my configuration. This is especially important since there are 1 query that failed and other questionable moments. Meanwhile, I'd glad to hear comments from interested.

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2025

CLA assistant check
All committers have signed the CLA.

@@ -0,0 +1,236 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These machine types were measured for Spark: c6a.2xlarge.json c6a.4xlarge.json c6a.xlarge.json c8g.4xlarge.json

Do you plan to add them as well or do you like me to do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can probably run that too after we finalize discussion on the PR.

@Iskander14yo

This comment was marked as resolved.

@Iskander14yo
Copy link
Contributor Author

@rschu1ze Currently I'm solving AWS issues related to my account and I don't know how long this will take. If you have an opportunity to run bench yourself I'd appreciate it. Otherwise I'll run it myself as soon as possible.

@rschu1ze
Copy link
Member

The PR LGTM. It will be hard for me to capture measurements on c6a.2xlarge.json, c6a.4xlarge.json, c6a.xlarge.json, and c8g.4xlarge.json in the next 1.5 weeks but if you find some time, please go ahead. Otherwise or if this is urgent, I can also merge this PR (just lmk).

@alexey-milovidov
Copy link
Member

@rschu1ze, we have the automation - please go ahead and merge. Then we can run on any machines in a matter of a single command.

@Iskander14yo
Copy link
Contributor Author

@alexey-milovidov current VM's (c6a.4xlarge) results should be re-run too since last changes.

@rschu1ze rschu1ze marked this pull request as ready for review August 11, 2025 07:08
@rschu1ze rschu1ze merged commit a79db08 into ClickHouse:main Aug 11, 2025
@Iskander14yo
Copy link
Contributor Author

@rschu1ze This PR shouldn't have been merged. It was still marked as Draft, because as I noted the benchmark needed to be re-run after the latest changes. I’ve opened a follow-up PR (#568) with corrected results for the current setup.

@alexey-milovidov
Copy link
Member

No problem, the most important part is that the scripts are ready. Thank you!

@alexey-milovidov
Copy link
Member

Good news, the script runs well, both on amd64 and aarch64.
I'm running it on a bunch of machines, so in 30 minutes, we should have updated results.

@alexey-milovidov
Copy link
Member

Except for the small machine, t3a.small:

Invalid maximum heap size: -Xmx0g
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants